+ Reply to Thread
Results 1 to 2 of 2

  Click here to go to the first Rift Team post in this thread.   Thread: Improvements to prevent false positives on the Addon Watchdog

  1. #1
    Sword of Telara DoomSprout's Avatar
    Join Date
    Apr 2011
    Posts
    876

    Default Improvements to prevent false positives on the Addon Watchdog

    This is in the patch notes, just thought I'd post what I understand the technical change to be.

    At the moment, the watchdog measures the amount of time it takes to execute an event handler (a bit of code within an addon that runs when something happens). If this piece of codes takes longer than 0.1s to run, RIFT throws a performance warning.

    The problem is, something else happening on the user's machine (including things like the user alt-tabbing out of RIFT) can cause the machine to spend time doing something other than running this code, which in turn means the time between the code starting and finishing ends up being over the threshold.

    With this change, the watchdog should now measure how much time is spent actually running the addon's code, ignoring any time the machine spends doing other stuff. I'm hopeful that with this change, the performance warnings are far more likely to trigger only when an addon is really taking a long time to do something.

    It's worth noting that there are some things within the addon API itself that take time to run (loading textures being the most obvious). It will be interesting to see whether waiting to read data from disk is included in the timings or not; it may not be as the thread is probably put to sleep while the OS waits for data to arrive from the disk.

    Fingers crossed, we'll all see a significant reduction in the number of performance warnings being thrown after this patch. It will take a week for them to drop out of the addon author's error emails, so we won't know for definite for a few days yet.

    Gadgets: Unit Frames and Other Stuff for RIFT

  2.   This is the last Rift Team post in this thread.   #2
    Rift Team
    Join Date
    Oct 2010
    Posts
    927

    Default

    Quote Originally Posted by DoomSprout View Post
    With this change, the watchdog should now measure how much time is spent actually running the addon's code, ignoring any time the machine spends doing other stuff. I'm hopeful that with this change, the performance warnings are far more likely to trigger only when an addon is really taking a long time to do something.

    It's worth noting that there are some things within the addon API itself that take time to run (loading textures being the most obvious). It will be interesting to see whether waiting to read data from disk is included in the timings or not; it may not be as the thread is probably put to sleep while the OS waits for data to arrive from the disk.
    This is accurate.

    Technically, it's counting the game and system CPU in the addon thread while an addon is running. This means that textures won't be "free" - it still burns CPU to read the data and decode whatever file format it's in - but it does mean that if the computer has high disk contention, Windows should put the thread to sleep and that won't count as CPU use.

+ Reply to Thread

Bookmarks

Posting Permissions

  • You may not post new threads
  • You may not post replies
  • You may not post attachments
  • You may not edit your posts