Minimap Buttons dock

[Adelea]

End user configuration is definitely planned - my philosophy is 'get it working, then make it pretty and configurable'.

The button selection is a layover from its early days, when I used left-click for something else. I think

Left - to drag
Right - popup small options panel
Left+Right - toggle lock

Is probably the more intuitive selection.

Options to change layout direction and label display are in the works.

Hadn't thought about keeping the docker open - this is dangerously close to turning the dock into a bar addon! But now you've brought it up, I can see the use to it.

Regarding the allcaps - I wanted something that wasnt likely to be used by something else - it's still early enough that I can change it if you really feel a need to.

With a relatively simple API, if someone else wants to write something that duplicates the functionality in a different way, they are free to do so, and if they recreate the API in the own addon, there should be little to no extra for work for addon authors once they add in support once.

[Adelea]

Which button doesnt light up, and under what circumstances ?

Ohhh... The icon for the dock location - just noticed it doesnt change color when lock state is changed...

Found and fixed the cause of that!

[DoomSprout]

Regarding the allcaps - I wanted something that wasnt likely to be used by something else - it's still early enough that I can change it if you really feel a need to.

Nah, no need at all, and it's not my place to tell anyone what naming conventions they should use. I shouldn't have mentioned it

[Nerva3x0]

I am putting the Docker button over the sort bag icon on the default bag frame. Every time I log in, it has moved about 1 inch above it previous position. Of course if I move it off any of Rifts default frames it stays there after logging. Just wondering if this is just an issue with the api or, something that can be fixed.

[Adelea]

I am putting the Docker button over the sort bag icon on the default bag frame. Every time I log in, it has moved about 1 inch above it previous position. Of course if I move it off any of Rifts default frames it stays there after logging. Just wondering if this is just an issue with the api or, something that can be fixed.

If you move the default bag frame, and put Docker where the bag frame used to be, does it still move?

If you put Docker in the same place relative to the new position of the bag frame, does it move?

Is it very close to the edge of the screen? I know I do some checks to see if it would be offscreen and move it if it would be - I wonder if that is the problem.

I cant think of anything else that would cause it - it records the X, Y coordinates and attempts to restore to them.

[Nerva3x0]

If you move the default bag frame, and put Docker where the bag frame used to be, does it still move?

If you put Docker in the same place relative to the new position of the bag frame, does it move?

Is it very close to the edge of the screen? I know I do some checks to see if it would be offscreen and move it if it would be - I wonder if that is the problem.

I cant think of anything else that would cause it - it records the X, Y coordinates and attempts to restore to them.

Yeah even if i move the bag frame it still moves it around 40 pixels or so up. It is not on the very edge of the screen really, I guess its fairly close to the bottom. I added some screens so you can get an idea of where it is. Like I said its on top of the sort button on the bag frame in the bottom right. When I log out, then back in, it will move the button about parallel with the roasting pig icon (lol)

[Adelea]

I dont understand why it is doing that!

The only time that the addon moves itself is:

If the X coord is off the left or right edges, it is changed so that it is on the edge

If the Y coord is off the top or bottom edges, it is changed so that it is on the edge

What does the following say (when in its original position, and after a relog (should be entered all one line)) ?

/script print(string.format("DX=%d, DY=%d, SX=%d, SY=%d", Docker_Settings.mmx, Docker_Settings.mmy, UIParent:GetWidth(), UIParent:GetHeight()))

[Nerva3x0]

I dont understand why it is doing that!

The only time that the addon moves itself is:

If the X coord is off the left or right edges, it is changed so that it is on the edge

If the Y coord is off the top or bottom edges, it is changed so that it is on the edge

What does the following say (when in its original position, and after a relog (should be entered all one line)) ?

/script print(string.format("DX=%d, DY=%d, SX=%d, SY=%d", Docker_Settings.mmx, Docker_Settings.mmy, UIParent:GetWidth(), UIParent:GetHeight()))

Ok, I think I did this like you asked. I logged in and it was moved like normal, then I entered the /script, then ran it again after resetting it to my desired location...any here is what it gave me

After logging in--> DX=1697, DY=1048, SX2207, SY1241
After moving it--> DX=1703, DY=1161, SX2207, SY1241

[Adelea]

Ok, I think I did this like you asked. I logged in and it was moved like normal, then I entered the /script, then ran it again after resetting it to my desired location...any here is what it gave me

After logging in--> DX=1697, DY=1048, SX2207, SY1241
After moving it--> DX=1703, DY=1161, SX2207, SY1241

I wonder...

From the numbers I guess your screen is 1920 x 1080, and you are running with a global UI scale of 0.87

So... The Y coordinate is 1161

Now, 1161(+32 to account for icon size) > 1080, so the addon does move it to ScreenHeight-32

1080 - 32 = 1048

So it looks like the effective screen size when I checkfor/reposition the icon hasnt taken into account the global UI scale.

I will see if I can find where that comes from, and what can be done about it.

This seems a bit like a bug also, so will flag it as such.

[Adelea]

This is in fact what is happening, on a fresh login, :GetHeight() and :GetWidth() return the actual screen size, and then later on, the coordinate system switches to an 'effective' state, where they are affected by the global UI scale.

I will remove the repositioning code from Docker, and instead make it a manual action if required.

[Nerva3x0]

This is in fact what is happening, on a fresh login, :GetHeight() and :GetWidth() return the actual screen size, and then later on, the coordinate system switches to an 'effective' state, where they are affected by the global UI scale.

I will remove the repositioning code from Docker, and instead make it a manual action if required.

I downloaded the updated version and everything is working as intended. And yeah my globalUI scale is around .87. TY for the help, and glad you got it fixed.