[ADDON] KM:Boss Mods

[Lorandii]

Semele has removed KBM from Curse. Hopefully he will reverse this decision, as losing this addon and Semele's tireless maintenance of it would be a huge loss to the game.

As a moderator over at Curse, under my Myrroddin name, I found KBM. However, I am not touching or moderating the project because Semele is still the valid author until further notice.

Semele did say he was doing minor alpha updates, bugfixes mostly, with nothing major or new, and that's good enough for me.

[Semele]

I think for the Rift API the mods are about as modular as they're going to get unfortunately. All they do pretty much on load is initiate their menu items and translations and build a trigger list. Other than that they sit their doing not much.

I could technically load their triggers based on location, but believe it or not this would probably alert the Watchdog more than trying to pre-load everything at start-up. The best way currently to defeat the Watchdog - or at least stay off its radar as much as possible - is to pre-render and pre-load as much as possible while the Watchdog is asleep at start-up.

Each Boss Mod for KBM just houses trigger info for the most part, and condition returning. Each one houses it's own save data, translations and start-end conditions. Other than that, KBM's engine is what drives everything. The engine runs practically identical if you're in a Warfront, Sanctum or in ID. You'll only notice CPU increases during encounters if it has to display timers or alerts. These are frames that re-render only when they need updating, and they obviously have a small impact on FPS.

[Semele]

v1.1.7

Unit Tracking
* Change: Moved Percent triggers in to a unified location within Unit:Update()

System
* Removed: All Watchdog diagnosis tracking and saving have been removed including associated commands.
* Fixed: Errors related to the diagnostic tools will now be gone.

Hammerknell Fortress
* Akylios
** Change: Removed P2 percentage trigger and replaced with the more reliable Emote trigger.

[Semele]

Borrowed the idea of Asynchronous Texture loading, currently implementing it. Not sure it'll actually avoid the Watchdog when a client system gets bogged down, but it's something at least *shrug.

I've not looked at Imhothar's Lib, but I would imagine they're not too far apart. KBM will soon use a smart caching system for loading textures during both start-up and during game play. During game play it's a 2 stage call on both Update events, during start-up it'll fire for Addon.Load.End.

The reason I wrote my own is that I don't use coroutines and I also don't need any sort of Cancel Texture, plus I enjoy creating new things. Not to mention I may introduce new things to it, or change it at the drop of a hat and therefor a fixed Lib maybe too static for my liking. The reason I can avoid cancelling Textures is because I instead update the texture with whatever the latest call to that texture was, slow queue processing will always only ever load the most recent Texture requested, allowing for Animation skipping if required.

Anyhow, the first alpha cycle of 1.1.8 will house this new system, and I'll monitor the results via my daily error reports from Trion. It does have a threshold I can adjust, so I can always tweak that, along with some system spike monitoring if need be.

[Semele]

This is the first draft, and so far seems to be working as intended. Very simple and small, but should serve its purpose.

-- King Boss Mods Texture Handler
-- Written By Paul Snart
-- Copyright 2012
--

local AddonData = Inspect.Addon.Detail("KBMTextureHandler")
local PI = AddonData.data

PI.Store = {}
PI.Queue = {
	Count = 0,
	List = {},
}

function PI.LoadTexture(Texture, Location, File)
	if not PI.Store[tostring(Texture)] then
		--print("Pushing unqueued Texture: "..Location.." - "..File)
		PI.Queue:Push(Texture, Location, File)
	else
		--print("Updating queued Texture: "..Location.." - "..File)
		PI.Store[tostring(Texture)].File = File
		PI.Store[tostring(Texture)].Location = Location
	end
end

function PI.Queue:Push(Texture, Location, File)
	if self.Count == 0 then
		local Entry = {
			Texture = Texture,
			Location = Location,
			File = File,
		}
		self.First = Entry
		self.Last = Entry
		PI.Store[tostring(Texture)] = Entry
		--print("New queue created")
	else
		local Entry = {
			Texture = Texture,
			Location = Location,
			File = File,
			Before = self.Last,
		}
		self.Last = Entry
		Entry.Before.After = Entry
		PI.Store[tostring(Texture)] = Entry
		--print("Adding to queue")
	end
	self.Count = self.Count + 1
end

function PI.Queue:Pop(Entry)
	--print("Removing: "..Entry.Location.." - "..Entry.File)
	if self.Count == 1 then
		self.First = nil
		self.Last = nil
		--print("Queue cleared")
	else
		self.First = Entry.After
		Entry.After.Before = nil
		--print("Queue count: "..self.Count)
	end
	PI.Store[tostring(Entry.Texture)] = nil
	self.Count = self.Count - 1
end

function PI.CycleLoad()
	if PI.Queue.Count > 0 then
		--print("Items in Queue: loading")
		repeat
			PI.Queue.First.Texture:SetTexture(PI.Queue.First.Location, PI.Queue.First.File)
			PI.Queue:Pop(PI.Queue.First)
		until Inspect.System.Watchdog() < 0.05 or PI.Queue.Count == 0
	end
end

table.insert(Event.System.Update.Begin, {PI.CycleLoad, "KBMTextureHandler", "Stage 1 Load Cycle"})
table.insert(Event.System.Update.End, {PI.CycleLoad, "KBMTextureHandler", "Stage 2 Load Cycle"})
table.insert(Event.Addon.Load.End, {PI.CycleLoad, "KBMTextureHandler", "Start Load Cycle"})

[Imhothar]

The reason I wrote my own is that I don't use coroutines and I also don't need any sort of Cancel Texture, plus I enjoy creating new things. Not to mention I may introduce new things to it, or change it at the drop of a hat and therefor a fixed Lib maybe too static for my liking. The reason I can avoid cancelling Textures is because I instead update the texture with whatever the latest call to that texture was, slow queue processing will always only ever load the most recent Texture requested, allowing for Animation skipping if required.

Not using coroutines either, just good old queues. You basically described exactly how my lib works, the same texture is never present twice and loads only the most recent request. Cancellation and callbacks are purely optional.

[Zaphrina]

Maelforge Final isn't working it still thinks its on eggs.

[bctrainers]

Maelforge Final isn't working it still thinks its on eggs.

edit; see below.

[Semele]

There is no end clause for the Dragon Eggs as of yet. You'll need to manually type /kbmreset before the pull.

[Nerva3x0]

Just wondering why the addon was removed from RiftUI.

[Thorarin]

Just wondering why the addon was removed from RiftUI.

For some reason the author was convinced that the RiftUI version of the download was corrupted, because he was getting error reports for which code line numbers that did not match up to the error and the reported addon version.

I think that conclusion was premature, because I've done a comparison between the two downloads, and the RiftUI download was perfectly fine. For some reason the RiftUI download is using *NIX style newlines while Curse is using DOS style newlines, which is why the files are all smaller on RiftUI. It does not explain why line numbering would be different however.

(Note that KBM TOC files from Curse always contain some extra junk)

[Lorandii]

(Note that KBM TOC files from Curse always contain some extra junk)

Said "extra junk" is what allows the Curse Client to find, update, version check installed vs Curse DB, and install addons. If RiftUI ever gets Minion updated to work with Rift, you will see different, yet similar "extra junk".

[Semele]

KBM has been re-enabled on RiftUI.

After some thorough testing it appears the file corruptions are NOT related to either RiftUI or Curse. From my findings, all files leave Curse and RiftUI perfectly intact.

What this does leave, with corrupt files, is the long journey from leaving both download sites, reaching the end-users machine and finally the act of decompressing the archive to install it. I do check all three downloads (RiftUI, Curse manual and Curse Client) for each release, and they've always been working fine.

If you have trouble with errors in KBM due to corrupt files, unfortunately the corruption happens at some point after leaving both sites and therefor there is nothing I, RiftUI or Curse can do to prevent this, you'll just need to delete the current files (download archive and installation folder in the Addons directory) and retry.

Apologies to RiftUI.

[Semele]

Commands
* New: /kbmdefault will now reset the position of both the Menu Button and Menu Window to central.
* New: The /kbmdefault command will also enable the Menu Button as visible and unlocked for positioning (Right Mouse Drag).
* Note: The /kbmdefault command will eventually be expanded upon to accept arguments, such as All, Button, Window, Timers, Alerts etc...
* Note: The Menu Window itself will soon gain "Default" and "Default All" buttons in various areas to compliment the new /kbmdefault command.

System
* Encounters
** Change: The encounter start specifics have now changed. Mods now have direct control over starting encounters.
** New: The Ignore List for untracked units is back, this should increase performance in many encounters.
** New: New Condition added to each trigger type for possible victories. (Not only Unit deaths can trigger a victory condition)
** New: Debug output now includes the X, Y, Z location of the trigger unit when combat started.
** Fixed: Added a new method to account for bosses with differing Type-ID's within the same encounter.
* Textures
** New: New system added which engages after initial caching of Textures. This handles all Texture Loading during game play.

Unit Tracking
* New: When removing units from the tracking system, they will also be removed from the Ignore List to prevent Memory leaking over time.

Infernal Dawn
* Ituziel
** New: Added Phase tracking.
** New: Added a secondary Flame Wave debuff watch for Tank-Swap. (Know for sure if a tank is double-tapped by waves)
* Ember Conclave
** Fixed: Assigned Traitorous Blood Mechanic Spy remove action to the correct Trigger. (Thanks to Ivnedar@Laethys)
** Fixed: Corrected Type ID for Traitorous Blood. (This should now trigger as designed)
* Laethys
** Change: Timer for Adds after the first has increased by 10 seconds.
* Maelforge - Dragon Eggs
** New: This encounter should now trigger.
** New: Added trigger for Phase Two (Magma Cannons)
** New: Added trigger for Final Phase (Dragon Eggs)
* Maelforge - Final
** New: This encounter should now trigger.
** New: Added Personal Alert, Mechanic Spy and Timer for Hellfire.
** New: Added Personal Alert for Earthen Fissure.
** New: Added Personal Alert for Fiery Fissure.

Primeval Feast
* Grandmaster Atrophinius
** New: Added Alert for Song of Anguish cast start.
** New: Added Mechanic Spy for Song of Anguish
* Swarmlord Khargroth
** New: Added Enrage Timer.
** New: Added Personal Alert for Acidic Vapors warning and duration with countdown.
** New: Added Minimum CD Timer for Poison Spray.
** New: Added Personal Alert for Chase mechanic.
** New: Added Mechanic Spy for Chase mechanic.
** New: Added Mechanic Spy for Acidic Vapors.
** New: Added Tank-Swap for Lethargic Venom.
** New: Added Minimum CD Timer for Acidic Vapors
** New: Added Timer for vanish phase transition. (Experimental 30 second duration)
** New: Added Phase Tracking for disaperance phases at 85%, 55% and 35% and associated stop triggers.
** New: Added Phase Tracking for final phase at 30%.
* Alltha the Reaper
** New: Added Mechanic Spy for Toxic Spore.

River of Souls
* Alsbeth the Discordant
** Change: Alsbeth now uses her Raid ID for triggering this encounter.

Translations
* French updates
* Russian updates and fixes.
* German partial updates.

[Semele]

v1.1.9

Mechanic Spy
* Fixed: Issue with new Static type timers attempting to initialize as nil rather than 0.

Infernal Dawn
* Ituziel
** Fixed: Trigger actually added to switch Ituziel's Phase Monitor to final phase.